Fix auto-recovery behavior for AMQ119002 producer failures by Havret · Pull Request #564 · Havret/dotnet-activemq-artemis-client

Havret · 2026-04-30T15:23:29Z

Fixes #562

Copilot

Pull request overview

This PR adjusts auto-recovery behavior for producers when the broker closes a producer link with terminal AMQP error conditions (notably AMQ119002 / amqp:not-found), preventing repeated recovery attempts that can flood logs.

Changes:

Treat ProducerClosedException with ErrorCode.NotFound (and UnauthorizedAccess) as terminal for AutoRecoveringProducer by terminating the producer instead of retrying/recovering.
Treat UnauthorizedAccess as terminal for AutoRecoveringAnonymousProducer by terminating the anonymous producer instead of retrying.
Add unit tests covering terminal close behavior for producer send/send-async and anonymous producer send/send-async.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
test/ArtemisNetClient.UnitTests/AutoRecovering/AutoRecoveringProducerSpec.cs	Adds tests asserting producers terminate (no further retries) when the producer link is closed with `amqp:not-found` (AMQ119002).
test/ArtemisNetClient.UnitTests/AutoRecovering/AutoRecoveringAnonymousProducerSpec.cs	New tests asserting anonymous producers terminate when link is closed with `amqp:unauthorized-access`.
src/ArtemisNetClient/AutoRecovering/AutoRecoveringProducer.cs	Terminates the auto-recovering producer for terminal broker-side close reasons (`UnauthorizedAccess`, `NotFound`) instead of retrying.
src/ArtemisNetClient/AutoRecovering/AutoRecoveringAnonymousProducer.cs	Terminates the auto-recovering anonymous producer on `UnauthorizedAccess` instead of retrying.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T17:13:39Z

+            var host = CreateOpenedContainerHost();
+            var linkProcessor = host.CreateTestLinkProcessor();
+


CreateOpenedContainerHost() opens a listening TestContainerHost, but this test doesn't dispose it. Please ensure host is disposed (e.g., using var host = ...) to avoid leaking resources/ports between tests.

@copilot apply changes based on this feedback

Fixed both test methods (Should_not_retry_SendAsync_when_producer_link_closed_with_not_found and Should_not_retry_Send_when_producer_link_closed_with_not_found) to use using var host = CreateOpenedContainerHost() for proper disposal. Commit: b25ba1c

Copilot · 2026-04-30T17:13:40Z

+        [Fact]
+        public async Task Should_not_retry_SendAsync_when_producer_link_closed_with_not_found()
+        {
+            var host = CreateOpenedContainerHost();


CreateOpenedContainerHost() opens a listening TestContainerHost, but this test never disposes it. Please wrap host in using (or dispose via DisposeUtil) to avoid leaking listeners across the test run.

Suggested change

var host = CreateOpenedContainerHost();

using var host = CreateOpenedContainerHost();

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+                catch (ProducerClosedException e) when (IsTerminalProducerException(e))
                {
                    await TerminateAsync(e).ConfigureAwait(false);


+                catch (ProducerClosedException e) when (e.ErrorCode is ErrorCode.UnauthorizedAccess)
+                {
+                    await TerminateAsync(e).ConfigureAwait(false);


+                catch (ProducerClosedException e) when (IsTerminalProducerException(e))
+                {
+                    TerminateAsync(e).GetAwaiter().GetResult();


                }
+                catch (ProducerClosedException e) when (e.ErrorCode is ErrorCode.UnauthorizedAccess)
+                {
+                    TerminateAsync(e).GetAwaiter().GetResult();


Havret · 2026-05-02T11:42:31Z

@copilot apply changes based on the comments in this thread

Copilot · 2026-05-02T12:16:30Z

@copilot apply changes based on the comments in this thread

Fixed in commit 35efb24. AutoRecoveringProducerBase.TerminateAsync now fires Closed?.Invoke(this) after disposing the underlying resource. This triggers OnRecoverableClosed in AutoRecoveringConnection, which unsubscribes event handlers and removes the producer from _recoverables — so it won't be recreated on subsequent connection recovery cycles.

Added tests for both the regular producer (Should_not_recreate_producer_on_connection_recovery_after_terminal_not_found_error) and the anonymous producer (Should_not_recreate_anonymous_producer_on_connection_recovery_after_terminal_unauthorized_access_error) to verify this behavior.

Havret · 2026-05-03T10:04:21Z

@copilot apply changes based on the comments in this thread

Copilot · 2026-05-03T10:05:06Z

@copilot apply changes based on the comments in this thread

That change was already applied in commit 0a2905a — both Should_not_retry_SendAsync_when_producer_link_closed_with_not_found and Should_not_retry_Send_when_producer_link_closed_with_not_found already use using var host = CreateOpenedContainerHost() for proper disposal.

Agent-Logs-Url: https://github.com/Havret/dotnet-activemq-artemis-client/sessions/9fa39fcb-f6d4-4ec4-92ea-543ba4755994 Co-authored-by: Havret <9103861+Havret@users.noreply.github.com>

…rom recovery set Agent-Logs-Url: https://github.com/Havret/dotnet-activemq-artemis-client/sessions/8bc2f1b9-864e-4a9f-a756-be8df181d7e6 Co-authored-by: Havret <9103861+Havret@users.noreply.github.com>

…on link closure

Havret mentioned this pull request Apr 30, 2026

Fix recovery loop spin on persistent link and connection failures #563

Closed

Havret requested a review from Copilot April 30, 2026 17:08

Copilot started reviewing on behalf of Havret April 30, 2026 17:09 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Copilot started work on behalf of Havret May 2, 2026 11:04 View session

Copilot finished work on behalf of Havret May 2, 2026 11:06

Havret requested a review from Copilot May 2, 2026 11:36

Copilot started reviewing on behalf of Havret May 2, 2026 11:37 View session

Copilot AI reviewed May 2, 2026

View reviewed changes

Copilot started work on behalf of Havret May 2, 2026 11:42 View session

Copilot finished work on behalf of Havret May 2, 2026 12:17

Havret force-pushed the fix/auto-recovery-amq119002-producer branch from 35efb24 to a61042b Compare May 3, 2026 10:04

Copilot started work on behalf of Havret May 3, 2026 10:04 View session

Copilot finished work on behalf of Havret May 3, 2026 10:05

Havret force-pushed the fix/auto-recovery-amq119002-producer branch from b8102a3 to 47261c6 Compare May 4, 2026 17:05

Havret and others added 6 commits May 4, 2026 19:42

Fix auto-recovery behavior for AMQ119002 producer failures

e1cbd8d

fix: wrap host in using statement in producer terminal close tests

1c9ea16

Agent-Logs-Url: https://github.com/Havret/dotnet-activemq-artemis-client/sessions/9fa39fcb-f6d4-4ec4-92ea-543ba4755994 Co-authored-by: Havret <9103861+Havret@users.noreply.github.com>

Fix TerminateAsync to fire Closed event so producer is unregistered f…

a162c5b

…rom recovery set Agent-Logs-Url: https://github.com/Havret/dotnet-activemq-artemis-client/sessions/8bc2f1b9-864e-4a9f-a756-be8df181d7e6 Co-authored-by: Havret <9103861+Havret@users.noreply.github.com>

Fix: invoke Closed event on consumer and request-reply client disposal

3c42d25

Fix: remove recoverable from set before terminating on exception

14b7a31

Fix: enhance ProducerClosedException with detailed error information …

0f12d8f

…on link closure

Havret force-pushed the fix/auto-recovery-amq119002-producer branch from 47261c6 to 0f12d8f Compare May 4, 2026 17:42

Havret merged commit 1404aa7 into master May 4, 2026
1 check passed

Havret deleted the fix/auto-recovery-amq119002-producer branch May 4, 2026 18:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix auto-recovery behavior for AMQ119002 producer failures#564

Fix auto-recovery behavior for AMQ119002 producer failures#564
Havret merged 6 commits into
masterfrom
fix/auto-recovery-amq119002-producer

Havret commented Apr 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Havret May 2, 2026

Uh oh!

Copilot AI May 2, 2026

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Havret commented May 2, 2026

Uh oh!

Copilot AI commented May 2, 2026

Uh oh!

Havret commented May 3, 2026

Uh oh!

Copilot AI commented May 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		var host = CreateOpenedContainerHost();
		var linkProcessor = host.CreateTestLinkProcessor();

	var host = CreateOpenedContainerHost();
	using var host = CreateOpenedContainerHost();

Conversation

Havret commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Havret May 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Havret commented May 2, 2026

Uh oh!

Copilot AI commented May 2, 2026

Uh oh!

Havret commented May 3, 2026

Uh oh!

Copilot AI commented May 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Havret commented Apr 30, 2026 •

edited

Loading